lkml.org 
[lkml]   [2006]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fsstack: Remove inode copy
On Fri, Dec 15, 2006 at 10:24:28AM -0600, Michael Halcrow wrote:
> The addition of copy_inode_size breaks eCryptfs, since eCryptfs needs
> to interpolate the file sizes (eCryptfs has extra space in the lower
> file for the header). The setting of the upper inode size occurs
> elsewhere in eCryptfs, and the new copy_attr_all now undoes what
> eCryptfs was doing right beforehand.
...
> I think the simplest solution, from eCryptfs' perspective, is to just
> remove the inode size copy. Jeff, please let me know if this approach
> will work for you, or let me know if you have another idea.

That's alright. fsstack is supposed to be as generic as possible. I think
that removing the inode size copy make it more generic.

> Remove inode size copy in general fsstack attr copy code. Stacked
> filesystems may need to interpolate the inode size, since the file
> size in the lower file may be different than the file size in the
> stacked layer.
>
> Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Acked-by: Josef "Jeff" Sipek <jsipek@cs.sunysb.edu>

Josef "Jeff" Sipek.

--
Don't drink and derive. Alcohol and algebra don't mix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-15 21:15    [W:0.029 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site