Messages in this thread | | | Subject | Re: [PATCH 2.6.20-rc1] ib_verbs: Use explicit if-else statements to avoid errors with do-while macros | From | Roland Dreier <> | Date | Wed, 13 Dec 2006 23:45:03 -0800 |
| |
> IOW, do ; while(0) / do { } while (0) is not a proper way to do a macro > that imitates a function returning void. > > Objections?
None from me, although the ternary ? : is a pretty odd way to write
if (blah) do_this_void_function(); else do_that_void_function();
so I'm in favor of that half of the patch anyway. It's my fault for not noticing that part of the patch in the first place.
Changing the non-void ? : constructions is just churn, but there's no sense changing it again now that the patch is merged.
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |