lkml.org 
[lkml]   [2006]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: SM501: core (mfd) driver
From
Date
On Wed, 2006-12-13 at 17:51 +0000, Ben Dooks wrote:
> > > +
> > > + writel(mode, sm->regs + SM501_POWER_MODE_CONTROL);
> > > +
> > > + dev_dbg(sm->dev, "gate %08lx, clock %08lx, mode %08lx\n",
> > > + gate, clock, mode);
> > > +
> > > + msleep(16);
> >
> > you're missing a PCI posting flush here
> > (if you don't know what this is please ask)
>
> Is this a read from an device register to cause the PCI writes
> to happen?

yup

> Would reading SM501_POWER_MODE_CONTROL be ok, or does
> it require a different register?

any register is ok, you can read the same one just fine.


greetings,
Arjan van de Ven
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-13 20:07    [W:0.042 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site