lkml.org 
[lkml]   [2006]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver
Hello.

Alan wrote:

>>+ * We work around this by initiating dummy, zero-length DMA transfer on
>>+ * a DMA timeout expiration. I found no better way to do this with the current

> Novel workaround and probably better than resetting the chip as the
> winbong does.

I didn't try resetting however the datasheet suggests it just won't do.

>>+static int tc86c001_busproc(ide_drive_t *drive, int state)
>>+{

> Waste of space having a busproc routine. The maintainer removed all the
> usable hotplug support from old IDE so this might as well be dropped.

Don't know what you mean, ioctl is still there...

>>@@ -1407,6 +1407,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x260a, quirk_intel_pcie_pm);
>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x260b, quirk_intel_pcie_pm);

>>+/*
>>+ * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
>>+ * but PIO transfer won't work if BAR0 falls at the odd 8 bytes.
>>+ * Re-allocate the region if needed.
>>+ */

> NAK. I think this fixup should be testing if the device port 0 is in
> native mode before doing the fixup. In comaptibility mode bar 0 is

The chip is native mode only.

> "Close but no cookie": please fix the PCI quirk to match the current -mm
> behaviour with the ATA resource tree. Otherwise - nice driver.

Ugh, I should've expected some backstab from -mm tree...

> Alan

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-13 15:43    [W:0.091 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site