Messages in this thread | | | Date | Wed, 13 Dec 2006 12:56:40 +1100 | From | Nick Piggin <> | Subject | Re: Status of buffered write path (deadlock fixes) |
| |
Trond Myklebust wrote: > On Wed, 2006-12-13 at 11:53 +1100, Nick Piggin wrote: > > >>Not silly -- I guess that is the main sticking point. Luckily *most* >>!uptodate pages will be ones that we have newly allocated so will >>not be in pagecache yet. >> >>If it is in pagecache, we could do one of a number of things: either >>remove it or try to bring it uptodate ourselves. I'm not yet sure if >>either of these actions will cause other problems, though :P >> >>If both of those are really going to cause problems, then we could >>solve this in a more brute force way (assuming that !uptodate, locked >>pages, in pagecache at this point are very rare -- AFAIKS these will >>only be caused by IO errors?). We could allocate another, temporary >>page and copy the contents into there first, then into the target >>page after the prepare_write. > > > We are NOT going to mandate read-modify-write behaviour on > prepare_write()/commit_write(). That would be a completely unnecessary > slowdown for write-only workloads on NFS.
Note that these pages should be *really* rare. Definitely even for normal filesystems I think RMW would use too much bandwidth if it were required for any significant number of writes.
I don't want to mandate anything just yet, so I'm just going through our options. The first two options (remove, and RMW) are probably trickier than they need to be, given the 3rd option available (temp buffer). Given your input, I'm increasingly thinking that the best course of action would be to fix this with the temp buffer and look at improving that later if it causes a noticable slowdown.
Thanks, Nick
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |