Messages in this thread | | | Date | Tue, 12 Dec 2006 14:24:28 -0800 | From | "Darrick J. Wong" <> | Subject | Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices |
| |
James Bottomley wrote:
> I thought we were closing in on agreeing that the SPC/MMC > inconsistencies made this the correct candidate fix.
I tried out the patch below, but with it applied, SCSI still issues REPORT LUNS to the device. It seems that sdev->type = -1 and bflags = 0 when scsi_get_device_flags is called because the type code is not set up until scsi_add_lun, which is called later. In any case, the check doesn't work for me because the SATAPI GoVault reports itself as a Direct Access device, not a CD-ROM.
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c <snip> > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c <empty>
Was there supposed to be more to this patch?
--D - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |