lkml.org 
[lkml]   [2006]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pipe: Don't oops when pipe filesystem isn't mounted
On Mon, 11 Dec 2006 09:21:30 +0000
Al Viro <viro@ftp.linux.org.uk> wrote:

> On Mon, Dec 11, 2006 at 01:13:27AM -0800, Andrew Morton wrote:
> > On Mon, 11 Dec 2006 00:55:57 -0800
> > Andrew Morton <akpm@osdl.org> wrote:
> >
> > > I think the bug really is the running of populate_rootfs() before running
> > > the initcalls, in init/main.c:init(). It's just more sensible to start
> > > running userspace after the initcalls have been run. Statically-linked
> > > drivers which want to load firmware files will lose. To fix that we'd need
> > > a new callback. It could be with a new linker section or perhaps simply a
> > > notifier chain.
> >
> > hm, actually... Add two new initcall levels, one for populate_rootfs() and
> > one for things which want to come after it (ie: drivers which want to
> > access the filesytem):
>
> IMO we should just call pipe (and socket) initialization directly at
> the same level as slab, task, dcache, etc.

spose that would work. But what other initcall-initialised things are not
yet available when populate_rootfs() runs?

<does grep _initcall */*.c>
<wonders why anything works at all>

> This is basic stuff needed to get operational kernel. We could try
> to put that on an additional initcall level, but then we ought to
> take the rest of basic setup there as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-11 10:33    [W:0.105 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site