lkml.org 
[lkml]   [2006]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.19-git13: uts banner changes break SLES9 (at least)


On Mon, 11 Dec 2006, Olaf Hering wrote:
>
> Please revert this change.

Well, that "get_kernel_version" is definitely buggered, and should be
fixed. And we do want the new behaviour for /proc/version.

So I don't think we should revert it, but we should:

- use separate strings for /proc/version and the static string. Because
there just isn't any point to sharing it that much, and the static
string might as well be made into __initdata, so you don't even lose
the 20-odd bytes of memory at run-time ;)

- strongly encourage "get_kernel_version" users to just stop using that
crap. Ask the build system for the version instead or something, don't
expect to dig it out of the binary (if you create an RPM for any other
package, you sure as _hell_ don't start doing strings on the binary and
try to figure out what the kernel is - you do it as part of the build)

What crud. I'm even slightly inclined to just let SLES9 be broken, just to
let people know how unacceptable it is to look for strings in kernel
binaries. But sadly, I don't think the poor users should be penalized for
some idiotic SLES developers bad taste.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.763 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site