Messages in this thread | | | Date | Thu, 30 Nov 2006 05:42:48 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c |
| |
Peer Chen wrote: > Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c. > The patch will be applied to kernel 2.6.19. > Please check attachment for the patch. > > Signed-off-by: Peer Chen <pchen@nvidia.com>
Please update as follows:
1) Provide a detailed explanation as to /why/ this is needed. I certainly encourage use of ahci over legacy mode, but the patch description tells us nothing.
2) Combine the two patches into one. Think of a patch as an atomic operation. If you apply your patches as submitted, then a 'git bisect' may reach a state where the PCI IDs exist in _neither_ sata_nv or ahci. Any time you /move/ code or data, it should be in the same patch.
3) Your patches are completely unreviewable in a standard Internet mailer, because they were sent with your email base64-encoded. For many mailers, base64 encoding means the patch is not shown nor able to be commented upon. Indeed, some mailers make it difficult to response -at all- to data contained in a MIME attachment.
The change itself seems OK, once suitable justification is provided.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |