Messages in this thread | | | From | Long Li <> | Subject | RE: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe with buf_size | Date | Thu, 25 Apr 2024 20:17:20 +0000 |
| |
> Subject: RE: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe with > buf_size > > > From: Long Li <longli@microsoft.com> > > Sent: Wednesday, 24 April 2024 01:35 > > To: Konstantin Taranov <kotaranov@linux.microsoft.com>; Konstantin > > Taranov <kotaranov@microsoft.com>; sharmaajay@microsoft.com; > > jgg@ziepe.ca; leon@kernel.org > > Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe > > with buf_size > > > > > Subject: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe > > > with buf_size > > > > I don't understand this commit message on "duplicate" cqe. I couldn't > > find a duplicate of it in the existing code. > > If we need cqe, we could use it at cq->ibcq.cqe. The patch does not assign it as it > is not used, but if you want I can add "cq->ibcq.cqe = attr->cqe;" in v2. > > - Konstantin
I see. We don't need buf_size because it can be computed from cq->ibcq.cqe?
The commit message is confusing enough to make people think cqe is a duplicate of buf_size.
Long
| |