lkml.org 
[lkml]   [2024]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/11] readahead: allocate folios with mapping_min_order in readahead
On Thu, Apr 25, 2024 at 01:37:39PM +0200, Pankaj Raghav (Samsung) wrote:
> + unsigned long index = readahead_index(ractl), ra_folio_index;

This is confusing. Uninitialised variables should go before initialised
ones. So either:

unsigned long ra_folio_index, index = readahead_index(ractl);
or
unsigned long index = readahead_index(ractl);
unsigned long ra_folio_index;

> + unsigned long i = 0, mark;

ditto


\
 
 \ /
  Last update: 2024-05-27 18:04    [W:0.289 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site