| Date | Thu, 25 Apr 2024 19:53:56 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v4 04/11] readahead: allocate folios with mapping_min_order in readahead |
| |
On Thu, Apr 25, 2024 at 01:37:39PM +0200, Pankaj Raghav (Samsung) wrote: > + unsigned long index = readahead_index(ractl), ra_folio_index;
This is confusing. Uninitialised variables should go before initialised ones. So either:
unsigned long ra_folio_index, index = readahead_index(ractl); or unsigned long index = readahead_index(ractl); unsigned long ra_folio_index;
> + unsigned long i = 0, mark;
ditto
|