Messages in this thread | | | Date | Thu, 25 Apr 2024 15:42:06 +0000 | From | Benno Lossin <> | Subject | Re: [PATCH 1/4] WIP: rust: Add basic KMS bindings |
| |
On 22.04.24 03:47, Lyude Paul wrote: > On Wed, 2024-03-27 at 20:50 +0000, Benno Lossin wrote: >> Hi, >> >> I just took a quick look and commented on the things that stuck >> out to me. Some general things: >> - several `unsafe` blocks have missing SAFETY comments, >> - missing documentation and examples. > > This is really early on - so I had wanted to post a WIP before I > actually wrote up everything to make sure I'm going in the right > direction (I'm certainly not planning on leaving things undocumented > when this is actually ready for submission :).
No worries, I just wanted to point out everything that I found.
One thing that I missed was your "RFC WIP" in your cover letter. I think that it's a good idea to put "RFC" onto every patch, that way people without context immediately know that it is not yet ready.
-- Cheers, Benno
| |