Messages in this thread | | | Date | Thu, 25 Apr 2024 08:45:37 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net] Fix a potential infinite loop in extract_user_to_sg() |
| |
On Thu, 25 Apr 2024 09:39:32 +0100 David Howells wrote: > Fix extract_user_to_sg() so that it will break out of the loop if > iov_iter_extract_pages() returns 0 rather than looping around forever.
Is "goto fail" the right way to break out here? My intuition would be "break".
On a quick read it seems like res = 0 may occur if we run out of iterator, is passing maxsize > iter->count illegal?
| |