Messages in this thread | | | Date | Thu, 25 Apr 2024 00:41:41 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/4] locking/atomic/x86: Silence intentional wrapping addition |
| |
On Wed, Apr 24, 2024 at 12:17:34PM -0700, Kees Cook wrote:
> @@ -82,7 +83,7 @@ static __always_inline bool arch_atomic_add_negative(int i, atomic_t *v) > > static __always_inline int arch_atomic_add_return(int i, atomic_t *v) > { > - return i + xadd(&v->counter, i); > + return wrapping_add(int, i, xadd(&v->counter, i)); > } > #define arch_atomic_add_return arch_atomic_add_return
this is going to get old *real* quick :-/
This must be the ugliest possible way to annotate all this, and then litter the kernel with all this... urgh.
| |