Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 6 May 2024 14:10:24 +0200 | Subject | Re: [PATCH v3 4/5] PCI: imx6: Convert to agnostic GPIO API |
| |
On Mon, Apr 29, 2024 at 12:25 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The of_gpio.h is going to be removed. In preparation of that convert > the driver to the agnostic API. > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I think there is a bug here, the code is respecting the OF property "reset-gpio-active-high" but the code in drivers/gpio/gpiolib-of.h actually has a quirk for this so you can just delete all the active high handling and rely on 1 = asserted and 0 = deasserted when using GPIO descriptors.
Just delete this thing: imx6_pcie->gpio_active_high = of_property_read_bool(node, "reset-gpio-active-high");
Yours, Linus Walleij
| |