Messages in this thread | | | Date | Wed, 1 May 2024 07:21:46 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH 08/10] writeback: factor out balance_domain_limits to remove repeated code |
| |
> @@ -1809,19 +1817,13 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > > nr_dirty = global_node_page_state(NR_FILE_DIRTY); > > - domain_dirty_avail(gdtc, false); > - domain_dirty_limits(gdtc); > - domain_dirty_freerun(gdtc, strictlimit); > - > - if (mdtc) { > + balance_domain_limits(gdtc, strictlimit); > + if (mdtc) > /* > * If @wb belongs to !root memcg, repeat the same > * basic calculations for the memcg domain. > */ > - domain_dirty_avail(mdtc, false); > - domain_dirty_limits(mdtc); > - domain_dirty_freerun(mdtc, strictlimit); > - } > + balance_domain_limits(mdtc, strictlimit);
Please keep the braces with the intervening comment. Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |