lkml.org 
[lkml]   [2024]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] writeback: factor out balance_domain_limits to remove repeated code
> @@ -1809,19 +1817,13 @@ static int balance_dirty_pages(struct bdi_writeback *wb,
>
> nr_dirty = global_node_page_state(NR_FILE_DIRTY);
>
> - domain_dirty_avail(gdtc, false);
> - domain_dirty_limits(gdtc);
> - domain_dirty_freerun(gdtc, strictlimit);
> -
> - if (mdtc) {
> + balance_domain_limits(gdtc, strictlimit);
> + if (mdtc)
> /*
> * If @wb belongs to !root memcg, repeat the same
> * basic calculations for the memcg domain.
> */
> - domain_dirty_avail(mdtc, false);
> - domain_dirty_limits(mdtc);
> - domain_dirty_freerun(mdtc, strictlimit);
> - }
> + balance_domain_limits(mdtc, strictlimit);

Please keep the braces with the intervening comment. Other than that,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun

\
 
 \ /
  Last update: 2024-05-27 18:11    [W:0.146 / U:2.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site