Messages in this thread | | | Date | Tue, 30 Apr 2024 16:14:03 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v4 13/12] net: lan865x: optional hardware reset |
| |
> In the spec, external RESET pin is mentioned as "if implemented", in my > understanding it is MAC-PHY vendors choice of implementing it where > Microchip is implemented it. Using this reset, can be a application > requirement/decision. It can be controlled from an external application > where it is not needed SPI to operate.
Since it is optional, controlling the reset pin is clearly not something for the TC6 core.
However, i doubt having an external application controlling the reset is a good idea. You don't want to reset during operation. So to me, this reset should be controlled by the driver. I tend to agree, that actually performing a reset is optional, but i would expect the driver to ensure the device is taken out of reset during probe, if the power on default of the board is to hold it in reset.
Andrew
| |