lkml.org 
[lkml]   [2024]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 1/1] drivers: watchdog: revise watchdog bootstatus
From
Date
On Mon, 2024-04-29 at 22:54 +0800, Peter Yin wrote:
> Hi Andrew,
> I am not sure how to add the Fixes tag, Is it like this?
>
> Fixes: 6a6c7b006e5c (watchdog: aspeed: Add support for
> aspeed,reset-mask DT property).

Approximately, yes, but it must not be wrapped.

Some more info is provided in the submitting-patches documentation:

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
>
> Is it the correct commit ID or should I base on which commit ID?
>

The correct commit ID to use is the one that introduces the problem.
Using `git blame drivers/watchdog/aspeed_wdt.c` it appears you're
changing the behaviour that was introduced in 49d4d277ca54 ("aspeed:
watchdog: Set bootstatus during probe"):

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49d4d277ca54e04170d39484c8758a0ea9bca37d

Andrew

\
 
 \ /
  Last update: 2024-05-27 18:08    [W:0.073 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site