Messages in this thread | | | Date | Mon, 29 Apr 2024 09:25:29 -0400 | From | Willem de Bruijn <> | Subject | Re: [PATCH net] net: drop pulled SKB_GSO_FRAGLIST skb |
| |
shiming.cheng@ wrote: > From: Shiming Cheng <shiming.cheng@mediatek.com> > > A SKB_GSO_FRAGLIST skb without GSO_BY_FRAGS is > expected to have all segments except the last > to be gso_size long. If this does not hold, the > skb has been modified and the fraglist gso integrity > is lost. Drop the packet, as it cannot be segmented > correctly by skb_segment_list. > > The skb could be salvaged. By linearizing, dropping > the SKB_GSO_FRAGLIST bit and entering the normal > skb_segment path rather than the skb_segment_list path. > > That choice is currently made in the protocol caller, > __udp_gso_segment. It's not trivial to add such a > backup path here. So let's add this backstop against > kernel crashes. > > Fixes: 3a1296a38d0c ("net: Support GRO/GSO fraglist chaining.") > Signed-off-by: Shiming Cheng <shiming.cheng@mediatek.com> > Signed-off-by: Lena Wang <lena.wang@mediatek.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
| |