Messages in this thread | | | Date | Mon, 29 Apr 2024 11:57:57 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] ACPI: Move acpi_blacklisted() declaration to asm/acpi.h |
| |
On Sun, Apr 28, 2024 at 09:04:41PM -0700, Kuppuswamy Sathyanarayanan wrote: > The function acpi_blacklisted() is defined only when CONFIG_X86 is > enabled and is only used by X86 arch code. To align with its usage and > definition conditions, move its declaration to asm/acpi.h
FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
..
> extern char acpi_video_backlight_string[]; > extern long acpi_is_video_device(acpi_handle handle); > -extern int acpi_blacklisted(void);
I would replace it with a blank line (to me it seems the above and below are different groups from semantic point of view, but Rafael may correct me).
> extern void acpi_osi_setup(char *str); > extern bool acpi_osi_is_win8(void);
-- With Best Regards, Andy Shevchenko
| |