Messages in this thread | | | From | Andy Lutomirski <> | Date | Mon, 29 Apr 2024 16:30:46 -0700 | Subject | Re: [PATCH] x86/mm: Remove broken vsyscall emulation code from the page fault code |
| |
On Mon, Apr 29, 2024 at 6:51 AM Jiri Olsa <olsajiri@gmail.com> wrote: > > On Mon, Apr 29, 2024 at 10:00:51AM +0200, Ingo Molnar wrote: > > SNIP > > > The attached patch looks like the ObviouslyCorrect(tm) thing to do. > > > > NOTE! This broken code goes back to this commit in 2011: > > > > 4fc3490114bb ("x86-64: Set siginfo and context on vsyscall emulation faults") > > > > ... and back then the reason was to get all the siginfo details right. > > Honestly, I do not for a moment believe that it's worth getting the siginfo > > details right here, but part of the commit says: > > > > This fixes issues with UML when vsyscall=emulate. > > > > ... and so my patch to remove this garbage will probably break UML in this > > situation. > > > > I do not believe that anybody should be running with vsyscall=emulate in > > 2024 in the first place, much less if you are doing things like UML. But > > let's see if somebody screams. > > > > Not-Yet-Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > Signed-off-by: Ingo Molnar <mingo@kernel.org> > > Link: https://lore.kernel.org/r/CAHk-=wh9D6f7HUkDgZHKmDCHUQmp+Co89GP+b8+z+G56BKeyNg@mail.gmail.com > > fwiw I can no longer trigger the invalid wait context bug > with this change > > Tested-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Andy Lutomirski <luto@kernel.org>
| |