lkml.org 
[lkml]   [2024]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [syzbot] [bpf?] [trace?] possible deadlock in force_sig_info_to_task
    On Sun, 28 Apr 2024 at 16:23, Hillf Danton <hdanton@sina.com> wrote:
    >
    > So is game like copying from/putting to user with runqueue locked
    > at the first place.

    No, that should be perfectly fine. In fact, it's even normal. It would
    happen any time you have any kind of tracing thing, where looking up
    the user mode frame involves doing user accesses with page faults
    disabled.

    The runqueue lock is irrelevant. As mentioned, it's only a symptom of
    something else going wrong.

    Now, judging by the syz reproducer, the trigger for this all is almost
    certainly that

    bpf$BPF_RAW_TRACEPOINT_OPEN(0x11,
    &(0x7f00000000c0)={&(0x7f0000000080)='sched_switch\x00', r0}, 0x10)

    and that probably causes the instability. But the immediate problem is
    not the user space access, it's that something goes horribly wrong
    *around* it.

    > Plus as per another syzbot report [1], bpf could make trouble with
    > workqueue pool locked.

    That seems to be entirely different. There's no unexplained page fault
    in that case, that seems to be purely a "take lock in the wrong order"

    Linus

    \
     
     \ /
      Last update: 2024-04-29 02:51    [W:5.249 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site