Messages in this thread | | | Date | Sun, 28 Apr 2024 17:24:06 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v20 2/5] ring-buffer: Introducing ring-buffer mapping functions |
| |
On Tue, 23 Apr 2024 12:04:15 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> > Nit: For all labels, please add a space before them. Otherwise, diffs will > > show "unlock" as the function and not "ring_buffer_map", making it harder > > to find where the change is. > > > > Isn't the inclusion of a space before labels outdate since 'git diff' > superseds 'diff' and fixed this issue?
I still use patch and quilt ;-) and that still suffers from that on reject files (used for backporting and such).
-- Steve
| |