Messages in this thread | | | Subject | Re: [RFC][PATCH 08/10] sched/fair: Implement delayed dequeue | From | Mike Galbraith <> | Date | Sun, 28 Apr 2024 18:32:49 +0200 |
| |
On Sat, 2024-04-27 at 08:42 +0200, Mike Galbraith wrote: > On Fri, 2024-04-26 at 18:03 +0200, Mike Galbraith wrote: > > fwiw, tbench liked the previous version better. > > The culprit lies somewhere in the new PREEMPT_SHORT patch.
<squint>
Ah, moving the curr eligibility check into pick_curr() left an ineligible curr to be seen/used further down in pick_eevdf().
found: if (!best || (curr && entity_before(curr, best))) best = curr;
Nit: PREEMPT_SHORT depending on RUN_TO_PARITY looks odd.
-Mike
| |