Messages in this thread | | | Date | Sun, 28 Apr 2024 14:52:50 +0200 | From | Markus Elfring <> | Subject | Re: [PATCH V2] scsi: qla2xxx: Fix double free of fcport in error handling path |
| |
… > Fix this by cleaning up the redundant qla2x00_free_fcport() and > replacing error handling with a goto chain. …
Can the following wording approach be a bit nicer?
Thus clean duplicate qla2x00_free_fcport() calls up and use more common error handling code instead.
> --- > drivers/scsi/qla2xxx/qla_iocb.c | 13 +++++-------- …
Unfortunately, you overlooked to add a patch version description behind the marker line.
See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n713
… > +++ b/drivers/scsi/qla2xxx/qla_iocb.c … > @@ -2787,6 +2783,7 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode, > > wait_for_completion(&elsio->u.els_logo.comp); > > +free_sp:
* I suggest to omit a blank line here.
* How do you think about to use the label “put_ref”?
> /* ref: INIT */ > kref_put(&sp->cmd_kref, qla2x00_sp_release); > return rval;
Regards, Markus
| |