Messages in this thread | | | Date | Sun, 28 Apr 2024 14:15:11 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 07/15] i2c: st: use 'time_left' variable with wait_for_completion_timeout() |
| |
Hello Wolfram,
On Sat, Apr 27, 2024 at 10:35:59PM +0200, Wolfram Sang wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' to > store the result of wait_for_completion_timeout() causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout) return -ETIMEDOUT; > > with all kinds of permutations. Use 'time_left' as a variable to make the code > self explaining. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I like the improvement in general and looking at this driver in more detail this looks right.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |