lkml.org 
[lkml]   [2024]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: drm/debugfs: Drop conditionals around of_node pointers
From
ping

在 2024/3/22 06:22, Sui Jingfeng 写道:
> Having conditional around the of_node pointer of the drm_bridge structure
> turns out to make driver code use ugly #ifdef blocks. Drop the conditionals
> to simplify debugfs.
>
> Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
> ---
> drivers/gpu/drm/drm_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index 08fcefd804bc..28a471fe4bc8 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -597,10 +597,10 @@ static int bridges_show(struct seq_file *m, void *data)
> drm_printf(&p, "\ttype: [%d] %s\n",
> bridge->type,
> drm_get_connector_type_name(bridge->type));
> -#ifdef CONFIG_OF
> +
> if (bridge->of_node)
> drm_printf(&p, "\tOF: %pOFfc\n", bridge->of_node);
> -#endif
> +
> drm_printf(&p, "\tops: [0x%x]", bridge->ops);
> if (bridge->ops & DRM_BRIDGE_OP_DETECT)
> drm_puts(&p, " detect");

--
Best regards
Sui Jingfeng


\
 
 \ /
  Last update: 2024-04-28 10:53    [W:0.069 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site