Messages in this thread | | | Date | Thu, 25 Apr 2024 06:34:54 -0700 | Subject | Re: [PATCH v3 1/2] dt-bindings: hwmon: adm1275: add adm1281 | From | Guenter Roeck <> |
| |
On 4/25/24 00:19, Conor Dooley wrote: > On Thu, Apr 25, 2024 at 03:09:47PM +0800, Jose Ramon San Buenaventura wrote: >> Add support for the adm1281 Hot-Swap Controller and Digital Power >> and Energy Monitor >> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com> > > I acked this, but I'm having second thoughts. The 1281 follows the same > codepaths in the driver as the 1278, why is the 1278 not used as a > fallback compatible here? >
That is rare for those devices es but true in this case. Technically possible, though it would result in a "Device mismatch" notification by the driver since it compares the configured vs. actual device IDs. I would prefer to avoid that, if for nothing else to avoid having to deal with concerned users.
Thanks, Guenter
| |