Messages in this thread | | | Date | Tue, 23 Apr 2024 15:17:22 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCHv10 03/18] cpu/hotplug: Add support for declaring CPU offlining not supported |
| |
On Fri, Apr 19, 2024 at 04:31:39PM +0300, Kirill A. Shutemov wrote: > Yes, it is one-off. I guess we could use READ_ONCE()/WRITE_ONCE() to > access the variable with the same result. I am not sure why it would be > better.
Nah, and it is not even the first one-off:
cpu_hotplug_disable/_enable() uses the same locking to update cpu_hotplug_disabled.
I guess we need to update the comment over cpu_maps_update_begin().
I guess this is fine wrt big picture of the CPU hotplug universe. Lemme point tglx to it just in case.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |