lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v19 094/130] KVM: TDX: Implement methods to inject NMI
    >+static void vt_set_nmi_mask(struct kvm_vcpu *vcpu, bool masked)
    >+{
    >+ if (is_td_vcpu(vcpu))
    >+ return;
    >+
    >+ vmx_set_nmi_mask(vcpu, masked);
    >+}
    >+
    >+static void vt_enable_nmi_window(struct kvm_vcpu *vcpu)
    >+{
    >+ /* Refer the comment in vt_get_nmi_mask(). */
    >+ if (is_td_vcpu(vcpu))
    >+ return;
    >+
    >+ vmx_enable_nmi_window(vcpu);
    >+}

    The two actually request something to do done for the TD. But we make them nop
    as TDX module doesn't support VMM to configure nmi mask and nmi window. Do you
    think they are worth a WARN_ON_ONCE()? or adding WARN_ON_ONCE() requires a lot
    of code factoring in KVM's NMI injection logics?

    \
     
     \ /
      Last update: 2024-03-29 03:14    [W:2.485 / U:1.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site