Messages in this thread | | | Date | Thu, 28 Mar 2024 19:11:30 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod |
| |
On Wed, 27 Mar 2024 19:43:29 +0800 Jijie Shao wrote: > + }, { > + .reg_name = "MIB_TX/RX_BAD_PKTS", > + .reg_offset_group = {19, 18, 29, 28}, > + .group_size = 4 > + }, { > + .reg_name = "MIB_TX/RX_GOOD_PKTS", > + .reg_offset_group = {21, 20, 31, 30}, > + .group_size = 4 > + }, { > + .reg_name = "MIB_TX/RX_TOTAL_PKTS", > + .reg_offset_group = {23, 22, 33, 32}, > + .group_size = 4 > + }, { > + .reg_name = "MIB_TX/RX_PAUSE_PKTS", > + .reg_offset_group = {25, 24, 35, 34}, > + .group_size = 4 > + }, { > + .reg_name = "MIB_TX_ERR_ALL_PKTS", > + .reg_offset_group = {27, 26}, > + .group_size = 2 > + }, { > + .reg_name = "MIB_RX_FCS_ERR_PKTS", > + .reg_offset_group = {37, 36}, > + .group_size = 2
These seem to be duplicating standard stats from rtnl_link_stats64, ethtool_pause_stats, ethtool_eth_mac_stats, etc.
You can add device specific stats, but please don't duplicate stats for which we have standard APIs.
| |