Messages in this thread | | | From | Yosry Ahmed <> | Date | Wed, 27 Mar 2024 15:34:15 -0700 | Subject | Re: [RFC PATCH 5/9] mm: zswap: remove zswap_same_filled_pages_enabled |
| |
On Tue, Mar 26, 2024 at 7:44 PM Chengming Zhou <chengming.zhou@linux.dev> wrote: > > On 2024/3/26 07:50, Yosry Ahmed wrote: > > There is no logical reason to refuse storing same-filled pages more > > efficiently and opt for compression. Remove the userspace knob. > > > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com> > > LGTM, should we also remove zswap_non_same_filled_pages_enabled? > Not sure if it has real usage...
I am not aware of usages, but in theory you can use it if you exclusively use zswap to optimize swapping zero-filled pages. Not sure if anyone actually does that though. We can remove it if everyone else agrees.
> > Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
Thanks!
| |