Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 10 Mar 2024 00:44:50 +0100 | Subject | Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver |
| |
On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote: > On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote: > > > > > > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl" > > > to match the compatible name in sm4450 pinctrl driver. > > > > > > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl") > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > index bb08ca5a1509..bb675c8ec220 100644 > > > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml > > > @@ -17,7 +17,7 @@ allOf: > > > > > > properties: > > > compatible: > > > - const: qcom,sm4450-pinctrl > > > + const: qcom,sm4450-tlmm > > > > I think you forgot to update the example: > > > > Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb: > > /example-0/pinctrl@f100000: failed to match any schema with > > compatible: ['qcom,sm4450-tlmm'] > > Still a warning in linux-next. Please send a fix.
I understand it as applying 1/2 is the fix so I applied it.
Yours, Linus Walleij
| |