Messages in this thread | | | Date | Sun, 10 Mar 2024 12:47:19 +0100 | Subject | Re: [PATCH net-next 2/4] net: dsa: realtek: keep default LED state in rtl8366rb | From | Krzysztof Kozlowski <> |
| |
On 10/03/2024 12:37, Simon Horman wrote: >>> >>> The code to disable LEDs was simplified only changing each LED group to >>> the RTL8366RB_LED_OFF state. Registers RTL8366RB_LED_0_1_CTRL_REG and >>> RTL8366RB_LED_2_3_CTRL_REG are only used when the corresponding LED >>> group is configured with RTL8366RB_LED_FORCE and they don't need to be >>> cleaned. The code still references an LED controlled by >>> RTL8366RB_INTERRUPT_CONTROL_REG, but as of now, no test device has >>> actually used it. Also, some magic numbers were replaced by macros. >>> >>> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> This is the first version, so where did review happen? > > FWIIW, I think this relates to review of an RFC of this patch-set. > > https://lore.kernel.org/netdev/CACRpkda8tQ2u4+jCrpOQXbBd84oW98vmiDgU+GgdYCHuZfn49A@mail.gmail.com/
OK, then this is v2. RFC is state of patch, not some sort of version. Or just use b4 which handles this automatically...
Best regards, Krzysztof
| |