Messages in this thread | | | From | Miguel Ojeda <> | Date | Sun, 10 Mar 2024 12:24:58 +0100 | Subject | Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline |
| |
On Sun, Mar 10, 2024 at 3:06 AM Ian Rogers <irogers@google.com> wrote: > > [1] https://clang.llvm.org/docs/AttributeReference.html#noinline > Reported-by: Christopher Di Bella <cjdb@google.com>
Out of curiosity, was this due to the `[[gnu::noinline]]` or similar in e.g. `src/string/memset_explicit.h`?
> -#define noinline __attribute__((__noinline__)) > +#define __noinline __attribute__((__noinline__))
I guess it does not matter since I don't see it used in `tools/`, but should the one inside `__fix_address` be updated too? Or is the idea to keep the diff as minimal as possible?
Cheers, Miguel
| |