lkml.org 
[lkml]   [2024]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V4 1/6] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY
On Wed, Feb 14, 2024 at 5:14 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> Hi Adam,
>
> On Sat, 10 Feb 2024 14:45:57 -0600
> Adam Ford <aford173@gmail.com> wrote:
>
> > From: Lucas Stach <l.stach@pengutronix.de>
> >
> > Add a DT binding for the HDMI PHY found on the i.MX8MP SoC.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> I was a bit puzzled by this v4 series as it comes after v8... however
> thanks for keeping up!

It was confusing to me to try and figure out where the latest of each
of the various components were found. I tried to explain it in the
cover letter, but basically the previous V8 was due to the fact that
some portion of it had been attempted 7 times. When it was brought to
my attention that the PHY driver I used was not he right one and the
HDMI-TX and the PVI driver were already applied, I reverted to using
the revision history of the version of the PHY driver I pulled which
was V3 and with my changes became V4.

I debated on making this V9, but inreality this code was only
attempted 3 times, and the subsequent device tree stuff had undergone
some changes, but it was easier to keep them paired together with the
PHY driver so the series could be applied as a whole.

I will be making a V5 due to some build-bot feedback and your
feedback, but I'll be sure to pull your tags when I try again. I just
want to give people around a week to mull it over and test it.

adam
>
> This patch is identical to the v8 I already reviewed, so:
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

\
 
 \ /
  Last update: 2024-05-27 15:02    [W:0.124 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site