Messages in this thread | | | Date | Wed, 14 Feb 2024 08:19:23 +1100 | From | Dave Chinner <> | Subject | Re: [RFC v2 13/14] xfs: add an experimental CONFIG_XFS_LBS option |
| |
On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav <p.raghav@samsung.com> > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
NAK.
There it no reason for this existing - the same code is run regardless of the state of this config variable just with a difference in min folio order. All it does is increase the test matrix arbitrarily - now we have two kernel configs we have to test and there's no good reason for doing that.
-Dave. -- Dave Chinner david@fromorbit.com
| |