Messages in this thread | | | Date | Wed, 14 Feb 2024 09:19:09 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH] riscv: use KERN_INFO in do_trap |
| |
On Tue, Feb 13, 2024 at 10:59:58AM +0100, Andreas Schwab wrote: > Print the instruction dump with info instead of emergency level like the > rest of the output when printing the information for an unhandled signal.
I'm not entirely sure that this is true, __show_regs() prints with KERN_DEFAULT, but this certainly is more consistent than it was before. Dumping at EMERG doesn't make sense to me though, so Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers, Conor.
> --- > arch/riscv/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index a1b9be3c4332..142f5f5168fb 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr) > print_vma_addr(KERN_CONT " in ", instruction_pointer(regs)); > pr_cont("\n"); > __show_regs(regs); > - dump_instr(KERN_EMERG, regs); > + dump_instr(KERN_INFO, regs); > } > > force_sig_fault(signo, code, (void __user *)addr);
[unhandled content-type:application/pgp-signature] | |