Messages in this thread | | | From | John Ernberg <> | Subject | Re: [PATCH net-next] net: fec: Always call fec_restart() in resume path | Date | Wed, 14 Feb 2024 08:27:02 +0000 |
| |
On 2/14/24 03:44, Jakub Kicinski wrote: > On Mon, 12 Feb 2024 10:50:30 +0000 John Ernberg wrote: >> Tested on 6.1 kernel and forward ported. I discovered this when we >> upgraded from 5.10 to 6.1, but the resume path in the FEC driver has had >> this imbalance since at least 2009. >> >> This is also why I target the -next tree, I can't identify a proper commit >> to blame with a Fixes. Let me know if this should be the net tree anyway. > > I thought you bisected it to one or two specific changes? > I'd put those down as Fixes tags and target net.
Hi Jakub,
You are correct, we thought so too at [1], but bisection is really hard because we need a whole bunch of patches on top to even boot the system (imx8qxp specific stuff in the NXP vendor tree that's difficult to rebase), we left it a bit open ended.
Over the course of the weekend I lost all confidence in my bisection after being confident for 4-5 days, because the more I thought about it the less it made sense for that commit to be the culprit.
I should probably have both followed up on that mail with that, and been clearer here. I apologize for failing that.
Best regards // John Ernberg
[1]: https://lore.kernel.org/netdev/1f45bdbe-eab1-4e59-8f24-add177590d27@actia.se/ | |