Messages in this thread | | | Date | Wed, 14 Feb 2024 17:02:03 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] dl2k: Fix potential NULL pointer dereference in receive_packet() |
| |
On Tue, 13 Feb 2024 23:09:00 +0300 Rand Deeb wrote: > + if (skb == NULL) {
if (!skb) is more common
> + np->rx_ring[entry].fraginfo = 0; > + printk (KERN_INFO > + "%s: receive_packet: " > + "Unable to re-allocate Rx skbuff.#%d\n", > + dev->name, entry);
no prints on allocation failure, please, there logs will include OOM splats already. A counter as suggested by Jake would be better. -- pw-bot: cr
| |