Messages in this thread | | | Date | Wed, 14 Feb 2024 07:34:40 +0100 | Subject | Re: [PATCH 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988 | From | Rafał Miłecki <> |
| |
On 13.02.2024 19:18, Conor Dooley wrote: > On Tue, Feb 13, 2024 at 05:46:32PM +0100, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> MT7988 has on-SoC controller that can control up to 8 PWMs. > > I see a binding and a dts patch, but no driver patch, how come?
I believe that to avoid cross-trees patchsets (which are sometimes tricky for maintainers) there are two ways of submiting such changes: 1. dt-binding + driver; then (separately) DTS 2. dt-binding + DTS; then (separately) driver
I chose later in this case as my personal priority right now is to deal with all MediaTek DTS files.
Is that wrong or unacceptable?
> Also, what makes this incompatibly different with the other devices in > the binding, like the 8183?
It can control 8 PWMs unlike any other SoC block except for MT2712. It uses different registers than MT2712 thought.
> Cheers, > Conor. > >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >> --- >> Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml >> index 0fbe8a6469eb..a5c308801619 100644 >> --- a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml >> +++ b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml >> @@ -24,6 +24,7 @@ properties: >> - mediatek,mt7629-pwm >> - mediatek,mt7981-pwm >> - mediatek,mt7986-pwm >> + - mediatek,mt7988-pwm >> - mediatek,mt8183-pwm >> - mediatek,mt8365-pwm >> - mediatek,mt8516-pwm >> -- >> 2.35.3 >>
| |