Messages in this thread | | | Date | Wed, 14 Feb 2024 12:31:35 -0800 | Subject | Re: [PATCH] net: stmmac: xgmac: fix initializer element is not constant error | From | Jacob Keller <> |
| |
On 2/12/2024 7:43 AM, Mark O'Donovan wrote: > GCC prior to 8.x gives an "initializer element is not constant" > error for the uses of dpp_tx_err in dwxgmac3_dma_dpp_errors. > Newer compilers accept either version. > > More info here: > https://lore.kernel.org/all/20240103-fix-bq24190_charger-vbus_desc-non-const-v1-1-115ddf798c70@kernel.org > > Signed-off-by: Mark O'Donovan <shiftee@posteo.net> > ---
I'm not sure whether the Linux kernel project has an explicit cutoff for what versions of GCC (or other compilers) are supported. GCC 8 was first released in 2018.
The fix provided here is fairly straight forward, and while I do think the benefit of using builtin types vs using the macros is nice, I don't see that as a strong enough reason to hold up supporting the older compiler.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 323c57f03c93..c02c035b81c0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -830,8 +830,8 @@ static const struct dwxgmac3_error_desc dwxgmac3_dma_errors[32]= { > { false, "UNKNOWN", "Unknown Error" }, /* 31 */ > }; > > -static const char * const dpp_rx_err = "Read Rx Descriptor Parity checker Error"; > -static const char * const dpp_tx_err = "Read Tx Descriptor Parity checker Error"; > +#define dpp_rx_err "Read Rx Descriptor Parity checker Error" > +#define dpp_tx_err "Read Tx Descriptor Parity checker Error" > static const struct dwxgmac3_error_desc dwxgmac3_dma_dpp_errors[32] = { > { true, "TDPES0", dpp_tx_err }, > { true, "TDPES1", dpp_tx_err }, > > base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de
| |