lkml.org 
[lkml]   [2024]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v3 10/19] net: ravb: Move delay mode set in the driver's ndo_open API
From
Date
On 1/5/24 11:23 AM, Claudiu wrote:

> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Delay parsing and setting were done in the driver's probe API. As some IP
> variants switch to reset mode (and thus registers content is lost) when
> setting clocks (due to module standby functionality) to be able to
> implement runtime PM keep the delay parsing in the driver's probe function
> and move the delay applying function to the driver's ndo_open API.
>
> Along with it, both delay specific functions were kept together.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index f386a3b7effb..946abd7606ca 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
[...]
> @@ -1772,6 +1825,8 @@ static int ravb_open(struct net_device *ndev)
> if (info->nc_queues)
> napi_enable(&priv->napi[RAVB_NC]);
>
> + ravb_set_delay_mode(ndev);
> +

Please consider moving to either ravb_dmac_init() or ravb_emac_init(),
at least in the future...

> /* Device init */
> error = ravb_dmac_init(ndev);
> if (error)
[...]

MBR, Sergey

\
 
 \ /
  Last update: 2024-01-06 21:27    [W:0.382 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site