lkml.org 
[lkml]   [2023]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 02/12] x86/cpufeature: Enumerate Key Locker feature
    Date
    Key Locker is a CPU feature to minimize exposure of clear-text key
    material. An encoded form, called 'key handle', is referenced for data
    encryption or decryption instead of accessing the clear text key.

    A wrapping key loaded in the CPU's software-inaccessible state is used
    to transform a user key into a key handle. On rarely unexpected
    hardware failure, the key could be lost.

    Here enumerate this hardware capability. It will not be shown up in
    /proc/cpuinfo as userspace usage is not supported. This is because
    there is no ABI to coordinate the wrapping-key failure.

    The feature supports Advanced Encryption Standard (AES) cipher
    algorithm with new SIMD instruction set like its predecessor (AES-NI).
    Mark the feature depending on XMM2. The new AES implementation will be
    in the crypto library.

    Add X86_FEATURE_KEYLOCKER to the disabled features mask at the moment.
    It will be enabled under a new config option.

    Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
    Reviewed-by: Dan Williams <dan.j.williams@intel.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: x86@kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    Changes from v6:
    * Massage the changelog -- re-organize the change descriptions

    Changes from RFC v2:
    * Do not publish the feature flag to userspace.
    * Update the changelog.

    Changes from RFC v1:
    * Updated the changelog.
    ---
    arch/x86/include/asm/cpufeatures.h | 1 +
    arch/x86/include/asm/disabled-features.h | 8 +++++++-
    arch/x86/include/uapi/asm/processor-flags.h | 2 ++
    arch/x86/kernel/cpu/cpuid-deps.c | 1 +
    4 files changed, 11 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
    index cb8ca46213be..4a12673df7e9 100644
    --- a/arch/x86/include/asm/cpufeatures.h
    +++ b/arch/x86/include/asm/cpufeatures.h
    @@ -389,6 +389,7 @@
    #define X86_FEATURE_AVX512_VPOPCNTDQ (16*32+14) /* POPCNT for vectors of DW/QW */
    #define X86_FEATURE_LA57 (16*32+16) /* 5-level page tables */
    #define X86_FEATURE_RDPID (16*32+22) /* RDPID instruction */
    +#define X86_FEATURE_KEYLOCKER (16*32+23) /* "" Key Locker */
    #define X86_FEATURE_BUS_LOCK_DETECT (16*32+24) /* Bus Lock detect */
    #define X86_FEATURE_CLDEMOTE (16*32+25) /* CLDEMOTE instruction */
    #define X86_FEATURE_MOVDIRI (16*32+27) /* MOVDIRI instruction */
    diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h
    index fafe9be7a6f4..eb841d694ed9 100644
    --- a/arch/x86/include/asm/disabled-features.h
    +++ b/arch/x86/include/asm/disabled-features.h
    @@ -38,6 +38,12 @@
    # define DISABLE_OSPKE (1<<(X86_FEATURE_OSPKE & 31))
    #endif /* CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS */

    +#ifdef CONFIG_X86_KEYLOCKER
    +# define DISABLE_KEYLOCKER 0
    +#else
    +# define DISABLE_KEYLOCKER (1<<(X86_FEATURE_KEYLOCKER & 31))
    +#endif /* CONFIG_X86_KEYLOCKER */
    +
    #ifdef CONFIG_X86_5LEVEL
    # define DISABLE_LA57 0
    #else
    @@ -126,7 +132,7 @@
    #define DISABLED_MASK14 0
    #define DISABLED_MASK15 0
    #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57|DISABLE_UMIP| \
    - DISABLE_ENQCMD)
    + DISABLE_ENQCMD|DISABLE_KEYLOCKER)
    #define DISABLED_MASK17 0
    #define DISABLED_MASK18 0
    #define DISABLED_MASK19 0
    diff --git a/arch/x86/include/uapi/asm/processor-flags.h b/arch/x86/include/uapi/asm/processor-flags.h
    index d898432947ff..262348aeaad1 100644
    --- a/arch/x86/include/uapi/asm/processor-flags.h
    +++ b/arch/x86/include/uapi/asm/processor-flags.h
    @@ -128,6 +128,8 @@
    #define X86_CR4_PCIDE _BITUL(X86_CR4_PCIDE_BIT)
    #define X86_CR4_OSXSAVE_BIT 18 /* enable xsave and xrestore */
    #define X86_CR4_OSXSAVE _BITUL(X86_CR4_OSXSAVE_BIT)
    +#define X86_CR4_KEYLOCKER_BIT 19 /* enable Key Locker */
    +#define X86_CR4_KEYLOCKER _BITUL(X86_CR4_KEYLOCKER_BIT)
    #define X86_CR4_SMEP_BIT 20 /* enable SMEP support */
    #define X86_CR4_SMEP _BITUL(X86_CR4_SMEP_BIT)
    #define X86_CR4_SMAP_BIT 21 /* enable SMAP support */
    diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid-deps.c
    index f6748c8bd647..200c5e69f78c 100644
    --- a/arch/x86/kernel/cpu/cpuid-deps.c
    +++ b/arch/x86/kernel/cpu/cpuid-deps.c
    @@ -81,6 +81,7 @@ static const struct cpuid_dep cpuid_deps[] = {
    { X86_FEATURE_XFD, X86_FEATURE_XSAVES },
    { X86_FEATURE_XFD, X86_FEATURE_XGETBV1 },
    { X86_FEATURE_AMX_TILE, X86_FEATURE_XFD },
    + { X86_FEATURE_KEYLOCKER, X86_FEATURE_XMM2 },
    {}
    };

    --
    2.17.1
    \
     
     \ /
      Last update: 2023-06-03 17:36    [W:2.877 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site