lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188
    From
    On 19/09/2022 11:56, Jianguo Zhang wrote:
    >> No, this does not justify new entry. You need specific compatible,
    >> but
    >> not new entry.
    >>
    >>> On the other hand, mt8188 and mt8195 have same ethernet design, so
    >>> the
    >>> private data "mt8195_gmac_variant" can be resued to reduce
    >>> redundant
    >>> info in driver.
    >>
    >> And you do not need new entry in the driver.
    > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for
    > ethernet in mt8188 DTS file?

    Yes, as a fallback. Example schema describes such case.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-09-19 12:07    [W:3.811 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site