lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 00/10] KVM: x86/mmu: simplify argument to kvm page fault handler
From
Date
On 26/05/21 23:10, Sean Christopherson wrote:
> - Have kvm_mmu_do_page_fault() handle initialization of the struct. That
> will allow making most of the fields const, and will avoid the rather painful
> kvm_page_fault_init().
>
> - Pass @vcpu separately. Yes, it's associated with the fault, but literally
> the first line in every consumer is "struct kvm_vcpu *vcpu = kpf->vcpu;".
>
> - Use "fault" instead of "kpf", mostly because it reads better for people that
> aren't intimately familiar with the code, but also to avoid having to refactor
> a huge amount of code if we decide to rename kvm_page_fault, e.g. if we decide
> to use that name to return fault information to userspace.
>
> - Snapshot anything that is computed in multiple places, even if it is
> derivative of existing info. E.g. it probably makes sense to grab

I agree with all of these (especially it was a bit weird not to see vcpu
in the prototypes). Thanks Sean for the review!

Paolo

\
 
 \ /
  Last update: 2021-06-10 14:47    [W:0.195 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site