lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 4/8] net: pc300too: move out assignment in if condition
    Date
    From: Peng Li <lipeng321@huawei.com>

    Should not use assignment in if condition.

    Signed-off-by: Peng Li <lipeng321@huawei.com>
    ---
    drivers/net/wan/pc300too.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
    index 17d5cb8..7d8eae5 100644
    --- a/drivers/net/wan/pc300too.c
    +++ b/drivers/net/wan/pc300too.c
    @@ -349,12 +349,14 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
    else
    card->n_ports = 2;

    - for (i = 0; i < card->n_ports; i++)
    - if (!(card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]))) {
    + for (i = 0; i < card->n_ports; i++) {
    + card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]);
    + if (!card->ports[i].netdev) {
    pr_err("unable to allocate memory\n");
    pc300_pci_remove_one(pdev);
    return -ENOMEM;
    }
    + }

    /* Reset PLX */
    p = &card->plxbase->init_ctrl;
    --
    2.8.1
    \
     
     \ /
      Last update: 2021-06-11 05:40    [W:4.149 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site