Messages in this thread | | | From | "Namjae Jeon" <> | Subject | RE: [PATCH][next] cifsd: fix kfree of uninitialized pointer oid | Date | Fri, 11 Jun 2021 09:40:24 +0900 |
| |
> From: Colin Ian King <colin.king@canonical.com> > > Currently function ksmbd_neg_token_init_mech_type can kfree an uninitialized pointer oid when the call > to asn1_oid_decode fails when vlen is out of range. All the other failure cases in function > asn1_oid_decode set *oid to NULL on an error, so fix the issue by ensuring the vlen out of range error > also nullifies the pointer. > > Fixes: 8bae4419ce63 ("cifsd: add goto fail in neg_token_init_mech_type()") > Addresses-Coverity: ("Uninitialized pointer read") > Signed-off-by: Colin Ian King <colin.king@canonical.com> I will apply, Thanks for your patch!
| |