lkml.org 
[lkml]   [2013]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] kernel: kallsyms: memory override issue, need check destination buffer length
    Date
    Chen Gang <gang.chen@asianux.com> writes:
    > We don't export any symbols > 128 characters, but if we did then
    > kallsyms_expand_symbol() would overflow the buffer handed to it.
    > So we need check destination buffer length when copying.
    >
    > the related test:
    > if we define an EXPORT function which name more than 128.
    > will panic when call kallsyms_lookup_name by init_kprobes on booting.
    > after check the length (provide this patch), it is ok.
    >
    > Implementaion:
    > add additional destination buffer length parameter (maxlen)
    > if uncompressed string is too long (>= maxlen), it will be truncated.
    > not check the parameters whether valid, since it is a static function.

    Found a bug already:

    kernel/kallsyms.c: In function ‘kallsyms_lookup’:
    kernel/kallsyms.c:305:78: error: negative width in bit-field ‘<anonymous>’
    kernel/kallsyms.c: In function ‘lookup_symbol_name’:
    kernel/kallsyms.c:327:78: error: negative width in bit-field ‘<anonymous>’
    kernel/kallsyms.c: In function ‘lookup_symbol_attrs’:
    kernel/kallsyms.c:346:69: error: negative width in bit-field ‘<anonymous>’

    Cheers,
    Rusty.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-04-15 06:21    [W:6.267 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site