lkml.org 
[lkml]   [2013]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] cgroup: implement task_cgroup_path_from_hierarchy()
On Sun, Apr 14, 2013 at 11:36:55AM -0700, Tejun Heo wrote:
> kdbus folks want a sane way to determine the cgroup path that a given
> task belongs to on a given hierarchy, which is a reasonble thing to
> expect from cgroup core.
>
> This patchset make hierarchy_id allocation use idr instead of ida and
> implement task_cgroup_path_from_hierarchy(). In the process, the
> yucky ida cyclic allocation is replaced with idr_alloc_cyclic().
>
> 0001-cgroup-refactor-hierarchy_id-handling.patch
> 0002-cgroup-drop-hierarchy_id_lock.patch
> 0003-cgroup-make-hierarchy_id-use-cyclic-idr.patch
> 0004-cgroup-implement-task_cgroup_path_from_hierarchy.patch
>
> 0001-0002 prepare for conversion to idr, which 0003 does.
>
> 0004 implements the new function.
>
> This patchset is on top of next-20130412 as idr_alloc_cyclic() patch
> is currently in -mm. Given that this isn't an urgent thing and the
> merge window is just around the corner, it'd be probably best to route
> these through cgroup/for-3.11 once v3.10-rc1 drops.
>
> These patches are also available in the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-task_cgroup_path_from_hierarchy
>
> And it actually reduces LOC. Woot Woot.
>
> include/linux/cgroup.h | 2
> kernel/cgroup.c | 128 +++++++++++++++++++++++++++++++++----------------
> 2 files changed, 89 insertions(+), 41 deletions(-)

Heh, I must have been tripping or something. 89 > 41. It's still a
lot cleaner tho. :)

--
tejun


\
 
 \ /
  Last update: 2013-04-15 06:01    [W:0.113 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site